Skip to content

Improve performance of SqlParser::getNextPlaceholder() method #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tigrov merged 3 commits into from
Feb 9, 2026
Merged

Improve performance of SqlParser::getNextPlaceholder() method #482

Tigrov merged 3 commits into from
Feb 9, 2026
+7 −14

Conversation

@Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 7, 2026

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues

Related PR

@Tigrov Tigrov mentioned this pull request Feb 7, 2026
Merged
@samdark
Copy link
Member

samdark commented Feb 7, 2026

Any benchmarks?

@samdark samdark requested a review from Copilot February 7, 2026 08:15
Copilot AI reviewed Feb 7, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes PostgreSQL SQL parsing by speeding up how the next placeholder is found, specifically by making identifier skipping more efficient inside SqlParser::getNextPlaceholder().

Changes:

  • Introduced a cached identifier character set (IDENTIFIER_CHARS) for fast scanning.
  • Replaced the per-character match loop in skipIdentifier() with a strspn()-based implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (da724f8) to head (c77e5f6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
- Coverage     96.70%   96.68%   -0.03%     
+ Complexity      408      406       -2     
============================================
  Files            67       67              
  Lines          1214     1206       -8     
============================================
- Hits           1174     1166       -8     
  Misses           40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov requested a review from Copilot February 7, 2026 08:50
Copilot AI reviewed Feb 7, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Tigrov
Copy link
Member Author

Tigrov commented Feb 7, 2026

Any benchmarks?

Yes, tested locally. Almost 2 times faster 🚀

image

@Tigrov Tigrov merged commit 101f814 into master Feb 9, 2026
3 checks passed
@Tigrov Tigrov deleted the improve-sql-parser branch February 9, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tigrov @samdark @vjik